feat(db/postgreSQL): Use user-named schema instead of public#58367
Draft
joshtrichards wants to merge 2 commits intomasterfrom
Draft
feat(db/postgreSQL): Use user-named schema instead of public#58367joshtrichards wants to merge 2 commits intomasterfrom
public#58367joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We've long assumed usage of the
publicschema in PostgreSQL, but this is a more of a legacy approach these days. Since pgsql 15 it's no longer the default behavior. Rather than using workarounds to toggle on and use the older approach, we can migrate to the modern approach.This is a backwards-compatible fix because it only affects the installation code path, which never runs again after initial setup. Existing installations continue working unchanged in public, while new installations benefit from better schema isolation and avoid the PostgreSQL 15+ permission issue entirely.
Separate follow-ups:
public/ add what's needed if/when relying on manual user creation)SELECT schemaname FROM pg_tables WHERE tablename LIKE 'oc_%' LIMIT 1;)TODO
Checklist
3. to review, feature component)stable32)